Lazy and concurrent command buffer evaluation#68
Merged
Conversation
MarconZet
changed the title
szymon-rd
approved these changes
Sep 10, 2025
cyfra-core/src/main/scala/io/computenode/cyfra/core/GBufferRegion.scala
Outdated
Show resolved
Hide resolved
cyfra-runtime/src/main/scala/io/computenode/cyfra/runtime/VkAllocation.scala
Outdated
Show resolved
Hide resolved
cyfra-runtime/src/main/scala/io/computenode/cyfra/runtime/PendingExecution.scala
Outdated
Show resolved
Hide resolved
MarconZet
force-pushed
the
mzlakowski/lazy-eval
branch
from
43d595e to
b4643d3
Compare
MarconZet
force-pushed
the
mzlakowski/lazy-eval
branch
from
b4643d3 to
cdb7900
Compare
szymon-rd
reviewed
Sep 11, 2025
| case b: VkBinding[?] => Some(b.buffer) | ||
| case _ => None | ||
|
|
||
| class VkBuffer[T <: Value: {Tag, FromExpr}] private (val length: Int, underlying: Buffer) extends VkBinding(underlying) with GBuffer[T] |
Member
There was a problem hiding this comment.
I am against putting multiple top-level public defs (classes) in one source file. It could be in the companion object if we aim for that.
Collaborator
Author
There was a problem hiding this comment.
rejected because it makes GBinding ugly
MarconZet
force-pushed
the
mzlakowski/lazy-eval
branch
from
ae35739 to
409e75d
Compare
MarconZet
added a commit
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.